base: Add shared zfs options to make links config live close to related config

machines/kholinar/default.nix

@@ -20,6 +20,7 @@
         };
       };
       zfs = {
+        enable = true;
         encrypted = true;
         backups = [
           {

machines/lasting-integrity/default.nix

@@ -28,6 +28,7 @@
       };
       nix.enableDirenv = false;
       zfs = {
+        enable = true;
         backups = [
           {
             path = "zroot/safe/data";

machines/urithiru/default.nix

@@ -27,6 +27,7 @@
         internalIPV4 = "192.168.0.1";
       };
       zfs = {
+        enable = true;
         backups = [
           {
             path = "zroot/safe/data";

modules/nixos/base/nix/default.nix

@@ -1,6 +1,5 @@
 { config, lib, pkgs, ... }:
 {
-  config = {
   chvp.base = {
     emacs.extraConfig = [
       ''
@@ -15,9 +14,7 @@
         :config (direnv-mode)
         )
     '';
-      zfs.homeLinks = (lib.optional config.chvp.base.nix.enableDirenv { path = ".local/share/direnv"; type = "cache"; });
   };
   nix.gc.dates = if config.chvp.base.nix.slowGc then "daily" else "hourly";
   programs.command-not-found.enable = false;
-  };
 }

modules/nixos/base/zfs/default.nix

@@ -1,48 +1,7 @@
 { config, lib, ... }:
 
 {
-  options.chvp.base.zfs = {
+  config = lib.mkIf config.chvp.base.zfs.enable {
-    encrypted = lib.mkOption {
-      default = false;
-      example = true;
-    };
-    systemLinks = lib.mkOption {
-      default = [ ];
-      example = [
-        { path = "/var/lib/docker"; type = "cache"; }
-        { path = "/var/lib/docker/volumes"; type = "data"; }
-      ];
-    };
-    homeLinks = lib.mkOption {
-      default = [ ];
-      example = [
-        { path = ".config/syncthing"; type = "data"; }
-        { path = ".cache/nix-index"; type = "cache"; }
-      ];
-    };
-    ensureSystemExists = lib.mkOption {
-      default = [ ];
-      example = [ "/data/etc/ssh" ];
-    };
-    ensureHomeExists = lib.mkOption {
-      default = [ ];
-      example = [ ".ssh" ];
-    };
-    backups = lib.mkOption {
-      default = [ ];
-      example = [{
-        path = "rpool/safe/data";
-        remotePath = "zdata/recv/<hostname>/safe/data";
-        fast = false;
-        location = "lasting-integrity.vanpetegem.me";
-      }];
-    };
-    rootDataset = lib.mkOption {
-      example = "rpool/local/root";
-    };
-  };
-
-  config = {
     chvp.dataPrefix = lib.mkDefault "/data";
     chvp.cachePrefix = lib.mkDefault "/cache";
 

modules/nixos/base/zsh/default.nix

@@ -73,8 +73,6 @@ let
 in
 {
   chvp.base.zsh.usersToConfigure = [ "charlotte" "root" ];
-  chvp.base.zfs.systemLinks = [{ path = "/root/.local/share/autojump"; type = "cache"; }];
-  chvp.base.zfs.homeLinks = [{ path = ".local/share/autojump"; type = "cache"; }];
 } // {
   home-manager.users = builtins.foldl' (a: b: a // b) { } (
     builtins.map

modules/shared/base/default.nix

@@ -3,6 +3,7 @@
 {
   imports = [
     ./nix
+    ./zfs
     ./zsh
   ];
 

modules/shared/base/nix/default.nix

@@ -36,6 +36,7 @@ in
   };
 
   config = {
+    chvp.base.zfs.homeLinks = (lib.optional config.chvp.base.nix.enableDirenv { path = ".local/share/direnv"; type = "cache"; });
     nix = {
       gc = {
         automatic = true;

modules/shared/base/zfs/default.nix

@@ -0,0 +1,49 @@
+{ config, lib, ... }:
+
+# Define shared options so that links configuration can live close to actual configuration
+{
+  options.chvp.base.zfs = {
+    enable = lib.mkOption {
+      default = false;
+      example = true;
+    };
+    encrypted = lib.mkOption {
+      default = false;
+      example = true;
+    };
+    systemLinks = lib.mkOption {
+      default = [ ];
+      example = [
+        { path = "/var/lib/docker"; type = "cache"; }
+        { path = "/var/lib/docker/volumes"; type = "data"; }
+      ];
+    };
+    homeLinks = lib.mkOption {
+      default = [ ];
+      example = [
+        { path = ".config/syncthing"; type = "data"; }
+        { path = ".cache/nix-index"; type = "cache"; }
+      ];
+    };
+    ensureSystemExists = lib.mkOption {
+      default = [ ];
+      example = [ "/data/etc/ssh" ];
+    };
+    ensureHomeExists = lib.mkOption {
+      default = [ ];
+      example = [ ".ssh" ];
+    };
+    backups = lib.mkOption {
+      default = [ ];
+      example = [{
+        path = "rpool/safe/data";
+        remotePath = "zdata/recv/<hostname>/safe/data";
+        fast = false;
+        location = "lasting-integrity.vanpetegem.me";
+      }];
+    };
+    rootDataset = lib.mkOption {
+      example = "rpool/local/root";
+    };
+  };
+}

modules/shared/base/zsh/default.nix

@@ -65,6 +65,8 @@ in
 
   config = {
     programs.zsh.enable = true;
+    chvp.base.zfs.homeLinks = lib.mkIf (builtins.elem username config.chvp.base.zsh.usersToConfigure) [{ path = ".local/share/autojump"; type = "cache"; }];
+    chvp.base.zfs.systemLinks = lib.mkIf (builtins.elem "root" config.chvp.base.zsh.usersToConfigure) [{ path = "/root/.local/share/autojump"; type = "cache"; }];
   } // {
     home-manager.users = builtins.foldl' (a: b: a // b) { } (
       builtins.map